Fix the default icon for the navigation block#44104
Merged
kevin940726 merged 1 commit intotrunkfrom Sep 13, 2022
Merged
Conversation
kevin940726
added
the
[Type] Bug
|
Size Change: -2 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Sep 13, 2022
Contributor
talldan
left a comment
talldan
left a comment
There was a problem hiding this comment.
Resolves the warnings for me, thanks for addressing it so quickly.
| } = {}, | ||
| hasIcon, | ||
| icon, | ||
| icon = 'handle', |
Contributor
There was a problem hiding this comment.
The block does have a default attribute of 'handle', so this may not be required, but I don't mind a bit of extra safety.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fix the default icon for the navigation block. Now the icon always fallback to the "handle" icon to preserve backward-compatibility, and to match both in the editor and in the frontend.
Why?
A follow-up to #43674 (comment). Fix the PHP error of accessing an undefined index.
How?
By adding
isset()to the PHP code and fallback to the handle icon in React.I'm not sure if it's worth it to require the icon to be defined and stored in the serialized output?
Testing Instructions