Merged
Conversation
ryanwelcher
approved these changes
May 24, 2022
Contributor
ryanwelcher
left a comment
There was a problem hiding this comment.
LGTM 👍 Thanks for updating this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Similar to #41272 that adds the information that the scaffolded block was tested with WordPress 6.0.
This PR fixes a few tiny issues I discovered when working on my own template for
@wordpress/create-block:https://github.com/gziolo/wp-block-directory-template
Why?
I noticed some linting errors reported and more importantly the block had usability issues caused by the block wrapper configured incorrectly.
How?
I updated templates for Create Block to import the block name from
block.jsonfile to remove the friction. I saw @ryanwelcher missing updating the hardcoded block name in his stream when he copied the block. This change removes the issue completely.I also updated
edit.jsimplementation in the Create a Block tutorial to use a wrappingdivto resolve usability issues in the UI when selecting the block.Finally, I added a few clarifications in the Create a Block tutorial to make it clear which files are referenced from the project.
Testing Instructions
Create a test plugin:
Upload the block plugin to the WordPress instance and ensure it works correctly. When you click on the block then all block controls should work as intended.