Closed
Conversation
Mamaduka
added
[Package] Compose
|
Size Change: +31 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
Contributor
|
I'm hesitant about this one, the reason is that this hook might become useless when we get the newly proposed The RFC hasn't been accepted yet but it's close I think and we could potentially start using the polyfill version in the current React version at that point. |
Member
Author
|
That's a good point—no need to introduce a new public API if we have to deprecate it soon. |
Member
Author
|
I'm going to close this one, in favor of better core hook :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #39911 (comment)
PR moves the
useLatestRefhook from the Components package utils (the package didn't use it) into Compose package.I also updated the Quote v2 block to use the new hook.
Testing Instructions
Unit tests are passing.