useSelect: update unit tests to testing-library#40229
Merged
Conversation
jsnajdr
added
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.22 MB ℹ️ View Unchanged
|
youknowriad
approved these changes
Apr 11, 2022
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
Makes sense. I have been doing similar refactors in my React 18 upgrade PR.
Member
Author
By the way, have you been looking at |
Mamaduka
approved these changes
Apr 11, 2022
Member
That would be interesting. |
Contributor
Not yet, no, mainly focusing on the e2e test failures. I did check very quickly but we have so much logic in useSelect that it's probably going to be a challenge. Feel free to give it a try. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
useSelectunit tests to use@testing-library/reactAPI instead of using the React test renderer directly.I'm working on some improvements to
useSelectasync mode (see #40093) and I'll need to add more unit tests to cover the functionality. This is the first step.