Conversation
|
Size Change: -58 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recent refactors to the canvas have surfaced a double-stacked gray bar at the bottom of the post editor, this one:
That's the metabox container, but it shows up as an empty gray bar even if you have no metaboxes. Here's how it looks when you do have metaboxes:
This PR refactors the metabox code to remove the gray bar unless you actually have metaboxes:
In doing so, I had to touch some of the border, margin and padding rules, which also polishes the metabox presentation itself:
How has this been tested?
Test the post editor with and without metaboxes such as the "Custom Fields" panel that you can enable in Preferences. With no metaboxes you should not see a double stacked footer bar, and when you do have metaboxes, they should be properly bordered.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).