Conversation
jsnajdr
added
[Type] Code Quality
jsnajdr
force-pushed
the
update/core-data-reducer-generation
branch
from
e8c5057 to
2712807
Compare
|
Size Change: -12 B (0%) Total Size: 1.92 MB
ℹ️ View Unchanged
|
Member
|
I think this needs rebasing/conflict resolution, and then can be merged. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
force-pushed
the
update/core-data-reducer-generation
branch
from
2712807 to
986419f
Compare
|
Flaky tests detected in 986419f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17153564416
|
Mamaduka
approved these changes
Aug 22, 2025
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
Let's merge this. The code looks good and CI checks should've caught anything I missed when testing manually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A little code quality improvement in the code that generates the
entitiesnested reducer fromentitiesConfig. When creating objects from arrays, useObject.fromEntriesinstead ofreduce( ( memo, ... ) ). Also, I added a comment that explains how the input and output data look like.