Fix getPxFromCssUnit test stability and test that memoized function works correctly#35939
Merged
Fix getPxFromCssUnit test stability and test that memoized function works correctly#35939
Conversation
|
Size Change: +1.83 kB (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
gziolo
approved these changes
Oct 26, 2021
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
Nice, thank for working on the follow up changes 👍🏻
gziolo
reviewed
Oct 26, 2021
| { unit: '40Q', expected: '38px' }, // 40 Q should be 1 cm | ||
| ]; | ||
|
|
||
| testData.forEach( ( data ) => { |
Member
There was a problem hiding this comment.
Jest also offers a useful helper functions describe.each and test.each that are sometimes good fit in cases like the one here.
Contributor
Author
There was a problem hiding this comment.
Thanks, I didn't know those existed! I will update the tests with those changes.
andrewserong
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pr updates the getPxFromCssUnit test to include testing the memoized function and makes sure that the cached version returns the same result as the memoized function.
Run the tests locally.
Related https://github.com/WordPress/gutenberg/pull/35205/files#r734296446
Types of changes
Do the tests pass?
Checklist:
*.native.jsfiles for terms that need renaming or removal).