Merged
Conversation
oandregal
added
[Type] Bug
|
Size Change: -26 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
Member
Author
|
Tested this with TT1, TT1-blocks, and Empty theme. Can't repro the bug so I believe this is fine to go. Going to fix the tests now. |
youknowriad
reviewed
May 5, 2021
| ); | ||
|
|
||
| const ELEMENTS = array( | ||
| 'link' => 'a:not(.wp-block-button_link)', |
Contributor
There was a problem hiding this comment.
It definitely makes sense to avoid tying the elements selector to specific block selectors.
If we do find an issue with the change, we may want to consider adding specificity to the block itself.
Member
Author
|
Updated the tests. |
jasmussen
approved these changes
May 5, 2021
Contributor
jasmussen
left a comment
jasmussen
left a comment
There was a problem hiding this comment.
This seems like a good change that adds only the necessary specificity, and it fixes the problem I was seeing with the navigation block. Before:
After:
I would encourage sanity checks by others more familiar with the intricacies of global styles, but from my perspective, this is a solid win. Thank you!
Member
Author
|
Going to go ahead with this so it can be part of 10.6. If folks report a scenario in which the button block (or any other) conflicts with this we can look at it separately. |
Contributor
|
I tested this against the old issue and I didn't see any regressions. Thanks - this is much cleaner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #30541 (comment)
:not(.wp-block-button_link)negation so buttons within groups didn't get styled with the link colorIt was reported to cause issues with navigations but also with any other block that may use the
aelement. This PR explores removing that negation.How to test