Make the navigation placeholder clearer.#30281
Merged
Conversation
|
Size Change: +354 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
mkaz
approved these changes
Apr 6, 2021
Member
mkaz
left a comment
mkaz
left a comment
There was a problem hiding this comment.
This tests well, looks clearer and I didn't see any problems with my testing, both navigation block and did not see any changes or issues within the navigation editor.
I assume you want the "(icon) Navigation" to show on vertical menus also, it does show and looks fine with the block, does not show on navigation editor.
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #30257.
This PR makes the navigation block placeholder clearer, and the buttons more clickable. Before:
After:
If no existing menu is present, the "Add all pages" button is primary:
This is the button that you should nearly always be using, so that your pages stay in sync and are added/removed automatically.
How has this been tested?
Please test horizontal and vertical navigation blocks on desktop and small viewports, verify things look right.
Checklist: