Navigation: Re-enable navigation block e2e tests#29543
Merged
Conversation
gwwar
commented
Mar 4, 2021
packages/block-editor/src/components/block-list/use-block-props/index.js
Outdated
Show resolved
Hide resolved
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
Contributor
|
There are some tests already: The nav block is currently plugin only so the tests are in the experiments folder. They're currently skipped (since #27018), would be great to re-enable them if it's the right time. |
Contributor
|
The REST endpoint mocking in those tests is a little bit difficult to work with, that's something I've also been dealing with in the navigation editor too (https://github.com/WordPress/gutenberg/blob/trunk/packages/e2e-tests/specs/experiments/navigation-editor.test.js). Not sure if it'd be sensible to abandon the use of REST mocking and just create the needed page/menus before each test and remove them after. The downside would be considerable time added to tests. |
Contributor
Author
Thanks @talldan I'll update the existing E2Es instead. I'm seeing some instability with the navigation block (it can crash based on click input in an empty menu) so we can re-enable E2E tests when that's fixed. It'll be too flakey for the full suite otherwise. I'll try to fix that in this PR unless someone else spots it first.
🤔 It might be worth creating a test plugin/theme for this if we'd like to test editing a non-trivial menu. |
Contributor
Author
|
I'd like to get #29391 fixed first before we re-enable E2E tests. I'm setting this back to draft for now. |
This was referenced Mar 8, 2021
gwwar
force-pushed
the
add/navigation-e2e
branch
from
1cf75aa to
c0f7ad0
Compare
…n placeholder UI from dropdown to buttons
gwwar
force-pushed
the
add/navigation-e2e
branch
from
b922fca to
6cd8ef1
Compare
gwwar
changed the title
Contributor
Author
Contributor
Author
|
Thanks for the review @ellatrix 💖 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27588 and re-enables navigation tests
It looks like the existing mocks still work, so we can maybe look into making test navigation data easier to work with in a follow up.
run.mp4
Testing Instructions
Verify that tests make sense and run well