Block Support: Separate opt in for font style and weight options#26844
Conversation
|
Tested and confirmed this is working as expected in the instructions. 👍 |
jorgefilipecosta
left a comment
There was a problem hiding this comment.
From the functional point view everything is working as expected 👍
packages/block-editor/src/components/font-appearance-control/index.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Not directly related to this PR but I left a comment regarding the current preset usage on fontStyle and fontWeight PR's.
These things are breaking change and may affect block markup so I guess it is something we should look at and decide as soon as possible
#26444 (review).
There was a problem hiding this comment.
This has been updated to have a separate value property in the presets.
Updates the recently added font appearance block support to separate the style and weight aspects in terms of opting in via block.json. This required: * Updating the detection of support opt in within typography tools * Updating the UI control to handle the situation when only one option is opted into This change also includes adding translation for the combined UI option labels and extracting concerns of how the selections are stored within style attributes from the UI control.
384528a to
6a4248e
Compare
|
This has now been rebased and updated to be compatible with recent introduction of |
apeatling
left a comment
There was a problem hiding this comment.
I ran through the testing instructions again after the recent changes, and can confirm everything worked as expected. 👍
Description
Updates the recently added font appearance block support to separate the style and weight aspects in terms of opting in via block.json.
This includes:
How has this been tested?
Manually.
Testing Instructions
packages/block-library/src/navigation/block.jsontoggling__experimentalFontStyleoff in the supports arrayblock.jsonagain toggling on__experimentalFontStyleand toggling off__experimentalFontWeightScreenshots
Types of changes
Breaking change.
This changes the block support flags for the font style/weight feature that was recently merged but not yet part of a release.
Checklist: