Fix support for SVG in rich text#24582
Closed
stokesman wants to merge 2 commits intoWordPress:trunkfrom
Closed
Conversation
stokesman
requested review from
cameronvoell,
ellatrix,
etoledom and
guarani
as code owners
stokesman
force-pushed
the
update/support-svg-in-rich-text
branch
from
50f8a86 to
0ca1aea
Compare
Contributor
Author
|
This is now #40496 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes support for SVG in
RichTextby adding simple logic to element/attribute creation for the use ofcreateElementNSandsetAttributeNSwhere appropriate. Adds a couple of test cases to cover expected behavior. Changes were made intending to do the simplest thing that could work for most use cases and not to fully support all SVG markup.Why
To enable SVG icons in rich text. Presently, adding SVG markup is possible and it will display properly on the frontend, but in the block editor, it does not display due to the elements being created without namespacing.
Demonstration
I've made a gist of a plugin that allows easy reproduction of the issue (also works to just run the JS in the console while on an editor screen). It adds a button to the rich text toolbar for inserting sample SVG markup.
How has this been tested?
Ran unit tests. Ran e2e tests with WordPress 5.4.2. Rich text related tests all passed.
Types of changes
Bugfix and added tests
Checklist: