Update/react native colours to variables#22985
Closed
enejb wants to merge 2 commits intoWordPress:trunkfrom
Closed
Update/react native colours to variables#22985enejb wants to merge 2 commits intoWordPress:trunkfrom
enejb wants to merge 2 commits intoWordPress:trunkfrom
Conversation
2 tasks
gziolo
added
the
Mobile App - i.e. Android or iOS
Member
|
@enejb, this PR need to be rebased. Is this refactor still valid but it was never reviewed and wasn’t land? Changes look reasonable. |
gziolo
added
the
[Status] Stale
Contributor
Author
|
Yes I am currently the hold up on this.
Will try to get it rebased and review soon. Out focus has slightly shifted
at the moment.
…On Fri, 27 Nov 2020 at 22:04, Greg Ziółkowski ***@***.***> wrote:
@enejb <https://github.com/enejb>, this PR need to be rebased. Is this
refactor still valid but it was never reviewed and wasn’t land? Changes
look reasonable.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#22985 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA4C75XZIQEE2IMYESEJL3SSCHHNANCNFSM4NYGHBRQ>
.
|
Contributor
Author
|
I am closing this for now since this PR should be done a different way as part of a project where we clean up the editor colours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR tries to fix wordpress-mobile/gutenberg-mobile#1783
By updating the hard coded colours with sass variables.
How has this been tested?
TBD
Screenshots
Floating tool bar (Spacer bar colour):
Before:
After: notice that the spacer bar matches the colour of the arrow.
Types of changes
Updated of the code to use the currently supplied sass colour variables.
Checklist: