Skip to content

Fix block-mover for images in column block#18196

Closed
mikeyarce wants to merge 1 commit intoWordPress:masterfrom
mikeyarce:fix-block-mover-for-column-images
Closed

Fix block-mover for images in column block#18196
mikeyarce wants to merge 1 commit intoWordPress:masterfrom
mikeyarce:fix-block-mover-for-column-images

Conversation

@mikeyarce
Copy link
Copy Markdown
Contributor

@mikeyarce mikeyarce commented Oct 30, 2019

Description

Move block-mover to left side for full or wide images inside column blocks to prevent them overlapping. Fixes #18195

How has this been tested?

  • Used the Gutenberg development environment to use WordPress locally
  • Tested on Firefox and Chrome at breakpoints 600px and up
  • Tested on latest master as of 96f7d34
  • Made sure that the full and wide image blocks outside of columns are not impacted

Screenshots

Wide Image in a Column block

Before
Screen Shot 2019-10-30 at 1 28 20 PM

After
Screen Shot 2019-10-30 at 1 41 25 PM

Full Width Image in a column block:

Before
Screen Shot 2019-10-30 at 1 39 53 PM

After
Screen Shot 2019-10-30 at 1 41 20 PM

Types of changes

  • SCSS changes, introducing new rules for column block wide and full images.
  • Fixes a layout bug

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

Move block-mover to left side for full or wide images inside column blocks to prevent them overlapping.
@karmatosed
Copy link
Copy Markdown
Member

@mikeyarce, unfortunately, there seem some conflicts, would you be able to get those resolved?

@mikeyarce
Copy link
Copy Markdown
Contributor Author

@karmatosed I'll take a look this week!

@karmatosed
Copy link
Copy Markdown
Member

Awesome thanks @mikeyarce

@ZebulanStanphill
Copy link
Copy Markdown
Member

Thanks to the G2 UI overhaul, the movers show up in a consistent location relative to the toolbar. This PR is no longer needed, so I'm closing it. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Column Block: Movers for Full and Wide Images inside columns are not visible

3 participants