Refactor core blocks to have save and transforms in their own files (part 1)#14882
Merged
Refactor core blocks to have save and transforms in their own files (part 1)#14882
Conversation
gziolo
added
[Package] Block library
gziolo
requested review from
Soean,
ajitbohra,
jorgefilipecosta,
noisysocks,
notnownikki,
talldan and
youknowriad
as code owners
14 tasks
jorgefilipecosta
force-pushed
the
update/block-library-file-extraction
branch
from
8b577b5 to
3262f10
Compare
jorgefilipecosta
approved these changes
Apr 12, 2019
Member
jorgefilipecosta
left a comment
jorgefilipecosta
left a comment
There was a problem hiding this comment.
I applied a rebase to make sure the tests execute attending to the last master changes.
Locally tests execute with success this is a case where packages/e2e-tests/specs/block-transforms.test.js is very useful.
The changes seem correct to me 👍
Feel free to merge after we get the green light.
Member
Author
I love them as well. They are super useful in this context. I hope that in the future we have at least one test for each block where test updates all block (non-media) attributes using keyboard interactions :) Thank you for testing and rebase. |
mchowning
pushed a commit
to mchowning/gutenberg
that referenced
this pull request
Apr 15, 2019
This was referenced Apr 15, 2019
Closed
Closed
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of aligning block library to Block Registration API RFC #13693.
It's all about moving
saveandtransformsto their own file to follow the proposal drafted in RFC. There might be some additional fields moved to their own files if I noticed that they were missed or introduced recently.Updated blocks:
How has this been tested?
npm testnpm run test-e2eManually tested whether all blocks load as before.