Add a forwardRef to wp.blockEditor.PlainText#14866
Merged
jorgefilipecosta merged 2 commits intomasterfrom Apr 9, 2019
Merged
Conversation
jorgefilipecosta
requested review from
ellatrix,
gziolo,
noisysocks,
talldan and
youknowriad
as code owners
gziolo
approved these changes
Apr 9, 2019
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
It looks good. It would be nice if CHANGELOG entry was more detailed.
gziolo
added
[Package] Components
Co-Authored-By: jorgefilipecosta <jorge.costa@developer.pt>
This was referenced Apr 15, 2019
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a simple change; it allows users of wp.blockEditor.PlainText to pass a reference to the component.
A reference may be useful for users, e.g., to manage the focus, in #14856 we use this functionality to focus a plain text field programmatically.
How has this been tested?
Verify the test cases pass.
In #14856 verify that for now, also contains the forwardRef add a menu item open the menu item menu and verify the edit label works.