Fix: media text vertical align fixture and block transforms structure.#14790
Merged
jorgefilipecosta merged 1 commit intomasterfrom Apr 3, 2019
Merged
Conversation
jorgefilipecosta
requested review from
aduth,
ajitbohra,
gziolo,
nerrad,
ntwb,
talldan and
youknowriad
as code owners
gziolo
added
[Type] Automated Testing
gziolo
approved these changes
Apr 3, 2019
jorgefilipecosta
deleted the
fix/media-text-vertical-align-and-transforms-test-info,
branch
12 tasks
youknowriad
removed
the
[Type] Bug
Contributor
|
This is not a bug right? |
This was referenced Apr 15, 2019
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I missed the rebasing with the master before merging #14625 which fixed media fixtures to work with the transforms tests and meanwhile a new media fixture was added.
This PR fixes the new media fixture following the same logic we applied on #14625.
How has this been tested?
I checked the automated tests pass.