Fix: Cover Block: Remove focal point attributes when they are not needed#14746
Merged
jorgefilipecosta merged 1 commit intomasterfrom Apr 2, 2019
Conversation
jorgefilipecosta
requested review from
Soean,
ajitbohra,
gziolo,
noisysocks,
notnownikki,
talldan and
youknowriad
as code owners
gziolo
added
the
Good First Review
gziolo
added
the
[Block] Cover
frontdevde
approved these changes
Apr 1, 2019
Contributor
frontdevde
left a comment
frontdevde
left a comment
There was a problem hiding this comment.
Thanks for fixing this! I tested all three test cases as described and can confirm that the behavior was as expected. 👍
jorgefilipecosta
deleted the
fix/cover-block-remove-focalpoints-on-video-and-on-fixed-background
branch
This was referenced Apr 15, 2019
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, on the cover block, the focal points attributes are not unset even when they are not needed/used e.g: when the background is a video or when the background is fixed.
This makes the markup more complex with attributes that are irrelevant.
How has this been tested?
Add a cover block with an image as background.
Change the focal points.
Enable the fixed background option.
Check on the code editor that there are no references to the focalPoint attribute.
Add a cover block with an image as background.
Enable the fixed background option.
Change the block to use a video background (using the media edit button + the media library).
Check on the code editor that there are no references to the hasParallax attribute.
Add a cover block with an image as background.
Change the focal points.
Change the block to use a video background (using the media edit button + the media library).
Check on the code editor that there are no references to the focalPoint attribute.