New admin styles are affecting styling of some components

[t-hamano]

As part of a visual refresh of the admin screens, there have been significant changes to the styling of form elements.

https://core.trac.wordpress.org/changeset/61645

These changes appear to have affected some component styles.

For example, the two issues I've identified so far are: We probably need a style to override the core form styles.

cc @WordPress/gutenberg-components @fabiankaegy

FormTokenField

The height is greater than 40px, which is affected by the new line-height value.

SelectControl

The text is misaligned when the size prop is small. This is affected by the new line-height value.

[mirka]

Also confirmed in Storybook by using the global style injector:

I guess I'll keep this my default setting for a while, to increase the chances of catching other issues.

[ciampo]

Given this is quite high-priority as a 7.0 bug fix, should we establish who's going to work on a fix?

[aduth]

It'd be good to get a better understanding of the full scope of potential impact of the change. Since the change seems to be motivated by alignment with many of these components, that would hopefully mitigate some divergence. I'd be curious if @fabiankaegy might be able to weigh in on potential impact, as the author of the original changes.

In my local investigation, my initial impression is that it may be limited to line-height, and specifically to SelectControl and FormTokenControl. I was also concerned about the min-height and padding changes, but AFAICT the components that would be impacted define their own styles which would supersede those on the bare element selector styles.

This also seems to reaffirm some past discussion about components being responsible for defining their own typographical styles to be more resilient to outside influence like this. It seems like FormTokenField and SelectControl would already be prone to this, since the line-height already existed in these form styles (and inherited into the component styles), just that the value was changed.

[t-hamano]

In my local investigation, my initial impression is that it may be limited to line-height, and specifically to SelectControl and FormTokenControl.

I'm having the same result. I've tested the entire component, and so fa,r those two seem to be the only issues we need to fix.

[ciampo]

Cool, so it seems like a relatively localized fix, and one that we would apply regardless of this specific report