-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Upload Media: follow up for PR feedback #75544
Copy link
Copy link
Closed
Labels
[Feature] Client Side MediaMedia processing in the browser with WASMMedia processing in the browser with WASM[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended
Metadata
Metadata
Assignees
Labels
[Feature] Client Side MediaMedia processing in the browser with WASMMedia processing in the browser with WASM[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended
Type
Fields
Give feedbackNo fields configured for Bug.
Description
Follow up to #74355
Follow-up fixes from PR review feedback on the client-side image sub-size generation feature.
1. Rename
vips.tstoindex.tsinstead of adding a separateindex.tsre-export fileFile:
packages/upload-media/src/store/utils/index.tsThe current
index.tsjust re-exports everything from./vips. Instead of having a separateindex.tsfile, we should simply renamevips.tstoindex.ts.2. Use
file:../vipsreference for@wordpress/vipsdependencyFile:
packages/upload-media/package.jsonThe
@wordpress/vipsdependency is currently set to"1.0.0-prerelease", but since it's a package in the same monorepo, it should use afile:../vipsreference instead.Parent issue
Part of #74333