DataViews flickers when clicking filter button

[t-hamano]

Description

If the current DataView has a default filter and you click the filter button, nothing happens, but the DataViews flickers.

I suspect that this problem is related to #71075, which introduced locked filters.

cc @oandregal @chihsuan

Step-by-step reproduction instructions

• Go to Appearance > Editor > Patterns. This screen is the easiest to see the problem.
• Click the filter button.

Screenshots, screen recording, code snippet

c3040c03a40058d770e1d5de23ec4cbc.mp4

Environment info

No response

Please confirm that you have searched existing issues in the repo.

• Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

• Yes

Please confirm which theme type you used for testing.

• Block
• Classic
• Hybrid (e.g. classic with theme.json)
• Not sure

[oandregal]

What is happening is the patterns screen only has 1 filter (sync status) and is set as primary (so it's always visible). Perhaps the filters button should be disabled in that scenario.

[SirLouen]

What is happening is the patterns screen only has 1 filter (sync status) and is set as primary (so it's always visible). Perhaps the filters button should be disabled in that scenario.

I'm just starting to dig rn, no real conclusions yet.
The first thing I've seen, is that in Templates, we have only one filter in the DataViews also, but they look like two different kinds of Filters. The Templates one is not flickering.

I've checked #71674 by @Adi-ty but I wondered: Even if we disable the button, isn't that jumping behavior buggy? It feels that disabling is just a patch that doesn't really fixes that flickering in the view.

[ntsekouras]

As a first step for this (and WP 7.0) we disabled the toggle button here.

@jameskoster suggested a way forward to properly resolve this issue (1, 2):

If a view config includes active filter, unset primary filters, or locked filters, the filter UI (chips) should be visible by default.
Filter visibility (toggle button state), and the 'add filter' / 'Reset' buttons, should be stored (maybe locally?) meaning:

1. If I add filters to the All Pages view, hide the filters, navigate away, then return, the filters should still be hidden.
2. If I add filters to the All Pages view, navigate away, then return, the filters should be visible.
3. If a view config includes active filter, unset primary filters, or locked filters, the filter UI (chips) should be visible by default.
4. Locked filters would always be hidden.