Child blocks are displayed in the block inserter and block visibility doesn't work

[t-hamano]

What problem does this address?

I found two issues in the trunk:

• Child blocks that have a specific parent, such as the List Item, are displayed. When you click on the block, it will say "Block "{blockName}" can't be inserted.". (This may be a new specification)
• "Manage block visibility" doesn't work.

I used git bisect and it looks like this issue occurred in #65490.

957141419a3cef7be97099ce0c69e8f8.mp4

cc @youknowriad @andrewserong @jorgefilipecosta

[youknowriad]

Thanks for catching the bug and creating the issue. It seems the new behavior to "compute insertion point" on the fly should only apply to specific conditions, not all the conditions of when a block is visible or not.

So it's like we need two different kind of selectors:

• Can insert block
• Is block visible

I'll explore something.

[youknowriad]

We should have e2e tests about the "manage block visibility" thing

[Mamaduka]

I think the #65700 only partially resolved the issue.

Child blocks that have a specific parent, such as the List Item, are displayed. When you click on the block, it will say "Block "{blockName}" can't be inserted.". (This may be a new specification)

This one remains. All child blocks are visible for the default root. The child blocks are no longer displayed when I select any container block, which causes a somewhat expensive re-render.

Screencast

CleanShot.2024-11-05.at.17.35.01.mp4

[t-hamano]

All child blocks are visible for the default root. The child blocks are no longer displayed when I select any container block, which causes a somewhat expensive re-render.

This is indeed a strange behavior. However, I remember that there was an effort to show all blocks in #62169. Should all blocks, including children, be shown in a container block?

[Mamaduka]

After #62169, you see all blocks in the inserter. When container sets allow children, they're displayed at the top, followed by the remaining blocks. Click on rest (non-allowed in the container) blocks; insert those after the container.

I think the current behavior for the default root ID ( ' ' ) is a bug.

@ellatrix, @youknowriad, what do you think?