Are shadow controls supposed to be enabled by default in classic themes?

[carolinan]

Description

I found it surprising that for a classic theme, I did not have to opt-in for the new shadows controls. They are enabled by default on the supported blocks.

Both custom spacing, color palettes, border, link color and now appearance tools have been opt-in, disabled by default.

How do theme developers opt-out of the feature?

Step-by-step reproduction instructions

On 6.5 alpha:
Activate a classic theme like Twenty Sixteen.
In the block editor, add an image, column or button
Open the block settings panel, locate the "Border and Shadow" panel.

Screenshots, screen recording, code snippet

No response

Environment info

6.5-alpha-57580

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

[hanneslsm]

I think this is part of #58298
CC @madhusudhand

Edit: @carolinan Just saw you engaged already in the specific PR and you're probably aware of the issue. Sorry, please ignore then.

[carolinan]

I got confused because looking at #58766 it only addressed theme.json, not classic themes.

@madhusudhand
Applying the PR keeps the shadow option in classic themes, but there are no presets. How do classic themes add presets? How do classic themes opt-out completely?

[annezazu]

Adding this to the 6.5 board for likely discussion and perhaps some quick fixes as this impacts adding appearance tools to classic themes. cc @tellthemachines and @andrewserong.

[tellthemachines]

@annezazu this feature is independent from appearance-tools; as I understand it this issue is about the inability to opt out of it in classic themes. The shadow feature has been in core for about a year though, so this can't strictly be classed as a regression.

[andrewserong]

@tellthemachines, while the shadow feature has been in core for a long time, I think the control at the block level in the block inspector is new, and landed only a few weeks ago: #57654 — so it might be something that needs following up on. I'll just ping @vcanales and @mikachan for visibility, too.

[tellthemachines]

Oh good point @andrewserong, then I guess this is still eligible to fix post-Beta.

[annezazu]

Yes! Sorry for not clarifying further. Those changes landed very recently and details matter.

[tellthemachines]

Sure, my main point is this issue is unrelated to appearance-tools. The shadow controls will always display in classic themes whether appearance-tools are enabled or not.

[andrewserong]

Looks like another PR landed last week that then consolidated shadow effects into the Border panel in #58466. It'd be good to confirm with @vcanales and @madhusudhand what the intended behaviour is, since there's been a bit of movement with these controls, and I wonder if that's a factor at play here 🤔

[andrewserong]

Update: I wonder if the problem is that the core lib/theme.json file has settings.shadow contain values and a set of default shadow presets:

gutenberg/lib/theme.json

Line 193 in 6e8d515

"shadow": {

This means that hasShadowControl will always be true, as the default state of the core theme.json is that it's (effectively) switched on because of that default value:

gutenberg/packages/block-editor/src/components/global-styles/border-panel.js

Line 153 in d0b9e7a

const hasShadowControl = useHasShadowControl( settings );

I'm not too sure what the fix could be here, given that default value (typically appearanceTools works by the default value being off or false, and then appearanceTools injects the expected truthy value). But hopefully that might help hone in on where the problem is 🙂

[getdave]

@madhusudhand Could you clarify what you see as the next steps here? 🙏