Insert / edit link inconsistencies across blocks

[afercia]

The insert/edit link toolbar behaves differently on the text block, image block, and cover image block. While the blocks have different nature, the action of inserting / editing / removing a link is always the same. As a user, I just want to insert a link, change it, or remove it.

Text block insert:

• "Apply" button: ok
• "Unlink" button: I haven't inserted a link yet, maybe it should be disabled?

Text block edit:

• I can edit and unlink 👍

Image block insert:

• the UI is different: the formatting toolbar disappears and there's a "Back" button to go back to it. I'd rather simplify and make it behave the same as the text block: show the formatting toolbar and the link toolbar
• there's an "Apply" button but no "Unlink" button. This should be consistent: always show Unlink (disabled) or never show

Image block edit:

• this brings me directly in "edit mode", it should be consistent with the text block and show me an initial view with the "Edit" and "Unlink" buttons
• there's no "Unlink" button: the only way to remove the link is: empty the field and click "Back" or click outside

Cover image insert:

• clicking on the image (not on the text): the UI allows me to insert a link; seems to me this doesn't produce any actual link, even if the UI shows me there's a link inserted... is this supposed to be used to add a link on the cover image text or on the image itself? both? Unclear.

Cover image edit:

• long links wrap in new lines (this doesn't happen on text and image blocks)

[jeffpaul]

This ticket was mentioned in Slack in #core-editor by jeffpaul. View the logs.

[karmatosed]

With all the work going on with links in #4909 lets close this and review after.