Skip to content

Fix welcome plugin: remember username, disable pingbacks, improve errors #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akirk wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Fix welcome plugin: remember username, disable pingbacks, improve errors #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd7f2bc
Fix welcome plugin: remember username, disable pingbacks, improve errors
akirk Jan 27, 2026
a665152
Rename plugin slug
akirk Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion blueprints/my-wordpress/blueprint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
"path": "blueprints/my-wordpress/plugin"
},
"options": {
"activate": true
"activate": true,
"targetFolderName": "playground-welcome"
}
}
]
Expand Down
36 changes: 26 additions & 10 deletions blueprints/my-wordpress/plugin/playground-welcome.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,10 +157,17 @@ public function render_page() {

<div class="field-group">
<label for="display_name"><?php echo esc_html__("What's your name?", 'playground-welcome'); ?></label>
<?php
$prefill_name = '';
if ($current_user->display_name && strtolower($current_user->display_name) !== 'admin') {
$prefill_name = $current_user->display_name;
}
?>
<input
type="text"
id="display_name"
name="display_name"
value="<?php echo esc_attr($prefill_name); ?>"
autofocus
>
</div>
Expand Down Expand Up @@ -224,8 +231,15 @@ public function render_page() {
method: 'POST',
body: formData
})
.then(response => response.json())
.then(data => {
.then(response => response.text())
.then(text => {
let data;
try {
data = JSON.parse(text);
} catch (e) {
throw new Error(text || 'Invalid response from server');
}

if (data.success) {
messageEl.className = 'welcome-message success';
messageEl.textContent = data.data.message;
Expand All @@ -235,18 +249,12 @@ public function render_page() {
window.location.href = '<?php echo esc_url(home_url('/')); ?>';
}, 1500);
} else {
messageEl.className = 'welcome-message error';
messageEl.textContent = data.data.message || 'An error occurred.';
messageEl.style.display = 'block';

button.disabled = false;
buttonText.style.display = 'inline';
buttonLoading.style.display = 'none';
throw new Error(data.data?.message || 'An error occurred.');
}
})
.catch(error => {
messageEl.className = 'welcome-message error';
messageEl.textContent = 'An error occurred. Please try again.';
messageEl.textContent = error.message || 'An error occurred. Please try again.';
messageEl.style.display = 'block';

button.disabled = false;
Expand Down Expand Up @@ -335,6 +343,9 @@ private function import_feed($feed_url, $max_items) {
$imported = 0;
$current_user_id = get_current_user_id();

remove_action('do_pings', 'do_all_pings', 10);
remove_action('publish_post', '_publish_post_hook', 5);

foreach ($items as $item) {
$title = $item->get_title();
$content = $item->get_content();
Expand All @@ -361,6 +372,8 @@ private function import_feed($feed_url, $max_items) {
'post_status' => 'publish',
'post_author' => $current_user_id,
'post_date' => $date ?: current_time('mysql'),
'ping_status' => 'closed',
'to_ping' => '',
]);

if ($post_id && !is_wp_error($post_id)) {
Expand All @@ -369,6 +382,9 @@ private function import_feed($feed_url, $max_items) {
}
}

add_action('do_pings', 'do_all_pings', 10);
add_action('publish_post', '_publish_post_hook', 5);

return [
'success' => true,
/* translators: %d: number of imported posts */
Expand Down