Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| * @wordpress-plugin | ||
| * Plugin Name: AI | ||
| * Plugin Name: AI Experiments | ||
| * Plugin URI: https://github.com/WordPress/ai |
There was a problem hiding this comment.
I wonder if it would be better to use an ai-experiments slug, as we are everywhere else, to continue to make it clear this really isn't intended as a production plugin. What do you think?
There was a problem hiding this comment.
I flagged this in the initial scaffold PR as using the slug ai feels pretty generic / prone to conflicts (particularly in some of the constant names we have). I'd still recommend ai-experiments (if we can) instead noting if we do agree on that, we'll need to update our textdomain and probably other places
There was a problem hiding this comment.
We have the ai slug reserved on WPORG, but we can still set the displayname to AI Experiments
There was a problem hiding this comment.
But why use up that slug for something experimental? Feels like it could be used by something intended for production later, like a canonical plugin?
There was a problem hiding this comment.
This is the canonical plugin, if something graduates from an experiment it's either going to core or we'd label it as such in this plugin. I do not see a world where there's and Experiments plugin and a non-experiments plugin for AI, the confusion that would cause seems not worth the separation in plugins.
There was a problem hiding this comment.
I see. So we wouldn't make another one, we'd graduate this one from experimental to non-experimental. Thanks! 👍
There was a problem hiding this comment.
I flagged this in the initial scaffold PR as using the slug ai feels pretty generic / prone to conflicts (particularly in some of the constant names we have). I'd still recommend ai-experiments (if we can) instead noting if we do agree on that, we'll need to update our textdomain and probably other places
@dkotter we've got the ai slug reserved on WPORG with the intent that the display name will be AI Experiments. We could update to an ai-experiments slug (php file, package, composer) if you feel that's best?
There was a problem hiding this comment.
No, I'm not overly worried about those things. Constants worry me a bit as it seems a high likelihood of conflicting when we're setting those as AI_ but that doesn't need to be changed here
JasonTheAdams
left a comment
There was a problem hiding this comment.
Couple suggestions, @jeffpaul, based on our conversation around the .org slug.
Co-authored-by: Jason Adams <jason.adams@automattic.com>
dkotter
left a comment
There was a problem hiding this comment.
Looks good to me, though noting since we're changing our minimum WP version from 6.8 to 6.9, if we merge this prior to 6.9 being released, you won't be able to install this plugin unless you're running a beta version of WP (which is why we changed it from 6.9 to 6.8 previously as it wouldn't install within Playgrounds)
I'm personally fine with this, given that it would do very little without Abilities, 6.9 will be releasing soon, and most people experimenting with this will know how to install the RC. |
What?
Relates to #28.
This pull request updates the plugin's branding and documentation to clarify its purpose as "AI Experiments" for WordPress, improves consistency across files, and updates metadata to match current project standards. The changes mainly affect documentation, plugin headers, and package configuration files.
Branding and Documentation Updates:
README.md,readme.txt,ai.php,composer.json, andpackage.jsonfor clarity and consistency. [1] [2] [3] [4]README.mdfor better project visibility and professionalism.Metadata and Requirements:
ai.phpandreadme.txt, and ensured license references use the SPDX identifier for consistency. [1] [2]repositoryfield topackage.jsonto provide a direct link to the GitHub repository.Cleanup:
README.mdto avoid duplication and confusion.Why?
Prepares plugin for WPORG standards ahead of submitting a 0.1.0 version to the WPORG Plugin Team for review.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Test using WordPress Playground
The changes in this pull request can be previewed and tested using this WordPress Playground instance:
Click here to test this pull request.