Remove unneeded function_exists checks#378
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #378 +/- ##
=============================================
+ Coverage 63.81% 63.89% +0.08%
+ Complexity 684 680 -4
=============================================
Files 49 49
Lines 3529 3518 -11
=============================================
- Hits 2252 2248 -4
+ Misses 1277 1270 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
function_exists checksfunction_exists checks
jeffpaul
left a comment
There was a problem hiding this comment.
Tested via Playground, OAI, and Title Gen worked as expected
What?
Remove unneeded
function_existschecksWhy?
As mentioned here, we have some
function_existschecks that aren't technically needed since the functions we check for are in versions of WordPress that match or exceed our minimum (6.9 and 7.0).How?
For any core WordPress functions that we know are always available in WordPress 7.0 (our minimum) remove
function_existschecksUse of AI Tools
None
Testing Instructions
Not a lot needed here other than ensuring tests pass. Could also test the Abilities Explorer experiment to ensure it still works as expected