Skip to content

[Documentation]: WordPress.PHP.POSIXFunctions#2460

Draft
jaymcp wants to merge 1 commit intoWordPress:developfrom
jaymcp:docs/WordPress.PHP.POSIXFunctions
Draft

[Documentation]: WordPress.PHP.POSIXFunctions#2460
jaymcp wants to merge 1 commit intoWordPress:developfrom
jaymcp:docs/WordPress.PHP.POSIXFunctions

Conversation

@jaymcp
Copy link
Copy Markdown
Contributor

@jaymcp jaymcp commented Jun 13, 2024

Description

This PR adds documentation for the WordPress.PHP.POSIXFunctions sniff.

Related issues/external references

Part of #1722

@jrfnl
Copy link
Copy Markdown
Member

jrfnl commented Jul 23, 2024

@jaymcp I noticed this PR is still in draft. Do you want me to review already ? Or are you still working on it ?

@rodrigoprimo
Copy link
Copy Markdown
Collaborator

@jaymcp, I was just wondering if you'll have a chance to finish this off in the near future. It would be great if this PR could be included in the next WPCS release.

If you haven't got time or lost interest, please let us know and we'll see if we can find someone to take over. Thanks!

@jaymcp
Copy link
Copy Markdown
Contributor Author

jaymcp commented Feb 7, 2025

Hey @rodrigoprimo. I haven't lost interest, but I have unfortunately not regained my capacity. Sadly my optimism about being able to return to work on this turned out to be unfounded. My apologies.

@jrfnl
Copy link
Copy Markdown
Member

jrfnl commented Feb 11, 2025

Hey @rodrigoprimo. I haven't lost interest, but I have unfortunately not regained my capacity. Sadly my optimism about being able to return to work on this turned out to be unfounded. My apologies.

Hi @jaymcp Sorry to hear that. Hope things will start looking up again soon.

Would you like one of us to take over the PR or would you prefer we leave it open for you to finish when you can ?

@jaymcp
Copy link
Copy Markdown
Contributor Author

jaymcp commented Feb 18, 2025

Hey @rodrigoprimo. I haven't lost interest, but I have unfortunately not regained my capacity. Sadly my optimism about being able to return to work on this turned out to be unfounded. My apologies.

Hi @jaymcp Sorry to hear that. Hope things will start looking up again soon.

Would you like one of us to take over the PR or would you prefer we leave it open for you to finish when you can ?

Thank you, @jrfnl, and sorry for the slow reply. As much as I'd like to be able to finish what I started, if these docs are to go into the next release, it would probably best to unassign me.

@rodrigoprimo
Copy link
Copy Markdown
Collaborator

@jrfnl @jaymcp, given that Jay mentioned they can't finish this PR and that WordPress.PHP.POSIXFunctions was deprecated in #2616 and will be removed in WPCS 4.0, I'm inclined to close this PR and remove this sniff from the list in #1722. What do you think?

@jrfnl
Copy link
Copy Markdown
Member

jrfnl commented Feb 4, 2026

given that WordPress.PHP.POSIXFunctions was deprecated in #2616 and will be removed in WPCS 4.0, I'm inclined to close this PR and remove this sniff from the list in #1722. What do you think?

I don't think that's the right move. Once all sniffs have docs, we will want to turn on the "do all sniffs have docs" check in the feature complete check, but we can't do that if there's still a sniff without docs.

Of course, that's not a problem if the docs aren't complete yet by the time we get to the WPCS 4.0 release, in which case this PR can be closed during the WPCS 4.0 dev cycle, but if we reach "doc complete" before 4.0, it will be a problem.

I suggest leaving this PR till last for the docs project (priority: low) and possibly fixing it up in a perfunctory manner if needs be.

@rodrigoprimo
Copy link
Copy Markdown
Collaborator

I suggest leaving this PR till last for the docs project (priority: low) and possibly fixing it up in a perfunctory manner if needs be.

Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants