Config: Allow multiple 'text' children in a single XML tag. #2216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imisnew2
commented
Jul 28, 2022
Comment on lines
+294
to
-292
| if node.children:any(function(n) return n.cdata end) then | ||
| meta.cdata:add(key) | ||
| return val |
Contributor
Author
There was a problem hiding this comment.
I'm not really sure what meta.cdata is tracking or what features it supports. I just added the key once if any of the text nodes had cdata. Before, it was asserting only one node could exist, so the condition used to be a simple 'if that one node has cdata' instead of 'if any node has cdata'.
| local val = '' | ||
| for child in node.children:it() do | ||
| if child.type == 'comment' then | ||
| meta.comments[key] = child.value:trim() |
Contributor
Author
There was a problem hiding this comment.
This was copied from what the other code path does -- the path when all children are tags or comments. Though it seems like this just ends up taking the value of the last comment vs storing all the comments. I don't know what meta.comments is used for.
Imisnew2
force-pushed
the
imisnew-config-multiple-text-children
branch
from
2ab9ee4 to
a1dde86
Compare
z16
pushed a commit
that referenced
this pull request
Nov 4, 2024
…hildren Config: Allow multiple 'text' children in a single XML tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to add comments to CDATA sections I manually added to a config file. This was giving me a 'malformed config' error, so I tried to fix the config library to allow this.