Fix crash with process_read_proc_file and uninitialised var #3
+36
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `process_read_proc_file` returns NULL there was a problem later on with uninitialized memory. Rebuilt the Process struct to reduce extra heap allocs and make sure there is always a string to copy to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
process_read_proc_filereturns NULL there was a problem later on with uninitialized memory, resulting in a crash. Easily reproducible on bazzite 43 by just opening the process list dialog and trying to exit it by pressing either cancel or ok. Reproducible with and without sudo.Rebuilt the Process struct to reduce extra heap allocs and make sure there is always a string to copy to.
Also resized other string arrays to powers of 2 for better memory locality (which probably doesn't matter).
Fixes #4