Replace occurrences of internal .data with Data(contentsOf:)

[rogerluan]

Hey 👋

While trying out Mocker, I tried replicating the happy path (according to the README) and wasn't able to. .data instance variable doesn't exist in URL, so then I thought it was a deprecated API, which got replaced by dataRepresentation. Turns out that dataRepresentation is different than the internal var data: Data { try! Data(contentsOf: self) } utility declared in the unit tests 😄 and this difference was causing Mocker to always return empty Data in the callback.

(lldb) po try! Data(contentsOf: MockedData.notesJSON)
▿ 585 bytes
  - count : 585
  ▿ pointer : 0x00007fb7b425e990
    - pointerValue : 140426978126224

(lldb) po MockedData.notesJSON.dataRepresentation
▿ 186 bytes
  - count : 186
  ▿ pointer : 0x00007fb7b427d160
    - pointerValue : 140426978251104

So this PR aims to make things more explicit and correct, on the documentation end. On the unit test sample code project we can leave things as is imo, because it helps readability and anyone can jump to definition if they wish to inspect what data is about 👍

[wetransferplatform]

	Messages
📖	View more details on Bitrise
📖	Mocker: Executed 25 tests, with 0 failures (0 unexpected) in 1.920 (1.944) seconds

Generated by 🚫 Danger Swift against 0d02a55

[AvdLee]

Thanks for bringing this up. Based on real experience for you as a user, this is super valuable. Hopefully, this will help making our project easier to understand for future users 💪 .

[wetransferplatform]

Congratulations! 🎉 This was released as part of Release 2.5.3 🚀

Generated by GitBuddy