evaluation metric questions

[JoonHo-Jang]

I want to ask you whether the calculation of 'known_acc' is correct or not, which is line number 169 in eval.py.

In my understanding, 'per_class_acc' in the function of 'test' has a length of (n.share+1). And, since 'open_class' is defined as "open_class = int(out_t.size(1))" in line 108, it is a "num_class = n_share + n_source_private".

However, the known accuracy is calculated by "known_acc = per_class_acc[:open_class - 1].mean()" in line 169.

Thus, when n_source_private>0, i think it covers all dimensions of per_class_acc.

In my thinking, it should be "known_acc = per_class_acc[:- 1].mean()" in line 169.

Please clarify my concerns.
Thank you.

[ksaito-ut]

Sorry for the confusion, and thanks for pointing out the issue.
I have changed the line.
See #1 about the discussion.

The changed one "known_acc = per_class_acc[:len(class_list)-1].mean()" should be fine, but, I think your answer is better.
I will keep the current version for now.