Skip to content

Minor frontend fixes #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaniilSmirnov merged 2 commits into from
Sep 8, 2025
Merged

Minor frontend fixes #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2c45d3
fixes
DaniilSmirnov Sep 5, 2025
96aec64
fix /lint
DaniilSmirnov Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ui/src/components/views/auth/auth-ldap-page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,11 @@ export const AuthLdapPage = () => {
</Button>
</FormItem>
</FormLayoutGroup>
<Button className={styles.contactButton} href={authContact} mode='link'>
{t('Contact Support')}
</Button>
<ConditionalRender conditions={[!!authContact, authContact != 'example.com']}>
<Button className={styles.contactButton} href={authContact} mode='link'>
{t('Contact Support')}
</Button>
</ConditionalRender>
</form>
</div>
</Group>
Expand Down
8 changes: 7 additions & 1 deletion ui/src/lib/utils/to-sentence-case.util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,7 @@
export const toSentenceCase = (str: string): string => str.charAt(0).toUpperCase() + str.slice(1).toLowerCase()
export const toSentenceCase = (str: string): string => {
if (str.includes('@')) return str

if (str.includes('.')) return str
Copy link
Collaborator

@irdkwmnsb irdkwmnsb Sep 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would mean that if a sentence ends with a dot - we don not capitalise the first letter. Is this expected?

Copy link
Author

@DaniilSmirnov DaniilSmirnov Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Usually names doesnt contains special symbols ofc


return str.charAt(0).toUpperCase() + str.slice(1).toLowerCase()
}