-
Notifications
You must be signed in to change notification settings - Fork 198
feat(Popover,Tooltip): add long-press trigger #9191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EldarMuhamethanov
wants to merge
8
commits into
master
Choose a base branch
from
e.muhamethanov/9091/tooltip-trigger-longpress
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(Popover,Tooltip): add long-press trigger #9191
EldarMuhamethanov
wants to merge
8
commits into
master
from
e.muhamethanov/9091/tooltip-trigger-longpress
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
e2e tests |
Contributor
Contributor
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9191/de26ab1222f70fb7330dee6fa9b069e15e17b633/pkg/@vkontakte/vkui/_pkg.tgzCommit de26ab1 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9191 +/- ##
==========================================
- Coverage 95.02% 94.76% -0.27%
==========================================
Files 419 423 +4
Lines 11183 11306 +123
Branches 4210 4238 +28
==========================================
+ Hits 10627 10714 +87
- Misses 556 592 +36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
inomdzhon
reviewed
Nov 20, 2025
Contributor
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-needs-work
Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Проблема
Сейчас тултипы на мобильных устройствах работают не очень правильно. Появляются при первом клике на тултип, закрываются при втором клике. И чтобы открыть его снова нужно сначала нажать в другое место. Это происходит потому, что на мобильном устройстве тултип реагирует на фокус в таргет-элемент
Решение
Поресерчив реализации тултипов в других либах, нашел реализацию в mui, где на мобильных устройствах тултип появляется при длительном нажатии на элемент. Решил выбрать такой же подход.
Изменения
useLongpress, который реализует логику вызова колбэка при долгом нажатия.useMatchMediaиuseHoverSupportedдля того, чтобы определять, что устройство, где открыто приложение не имеет ховераPopover,Tooltipдополнительныйtrigger-"longpress", а также свойствоlongpressDelay, которое позволяет изменить время нажатия.Tooltipлогику, что при отстутсвии ховера на устройстве тригером становилсяlongpressRelease notes
Улучшения
longpress