Added new icon for Eruda, and now works in tab view.#326
Conversation
✅ Deploy Preview for curious-biscotti-765c40 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
|
It's not hard to make it work in tab view. |
Contributor
Author
|
As I said, it does. |
Contributor
|
Beat me to it 😏 |
Contributor
Author
|
This should be mergable now, I added a nice icon. |
Contributor
|
mm |
VillainsRule
suggested changes
Dec 13, 2023
Contributor
|
aww I can't merge it |
xbubbo
added a commit
that referenced
this pull request
Apr 4, 2024
Added new icon for Eruda, and now works in tab view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only catch is that it will only work in tabs view if you go to a website using Interstellar's built in search box. This will NOT work if you go to a website using the tab's view's integrated address bar.Never mind it does work