Added Eruda support for non-tab view#323
Merged
Conversation
Doesn't load on tabs for some reason.
✅ Deploy Preview for curious-biscotti-765c40 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
VillainsRule
suggested changes
Dec 11, 2023
Contributor
VillainsRule
left a comment
VillainsRule
left a comment
There was a problem hiding this comment.
good idea. needs work.
| iframe.src = encodedUrl; | ||
|
|
||
| iframe.onload = function() { | ||
| let iframeDocument = iframe.contentDocument || iframe.contentWindow.document; |
Contributor
There was a problem hiding this comment.
contentDocument should be the fallback. contentWindow is more supported.
Additionally, use iframe.contentWindow?.document in case it throws and error.
Removed redundant ``` iframeDocument.body.appendChild(script); ```
xbubbo
added a commit
that referenced
this pull request
Apr 4, 2024
Added Eruda support for non-tab view
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.