-
-
Notifications
You must be signed in to change notification settings - Fork 915
CURA-12894 honeycomb infill #2272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
rburema
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: cfb52a3 | Previous: 3620612 | Ratio |
|---|---|---|---|
SimplifyTestFixture/simplify_local |
8.697128722396387 ns/iter |
1.244845310316953 ns/iter |
6.99 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @nallath @jellespijker @wawanbreton @casperlamboo @saumyaj3 @HellAholic
This PR adds 2 new infill types:
As a bonus, it also adds the ability to set an angle on gyroid infill, since the new infills share code with gyroid and they have to handle orientation.
Requires Ultimaker/Cura#21286
CURA-12894