Skip to content

Conversation

@stiber
Copy link
Contributor

@stiber stiber commented Oct 29, 2024

Closes #

Description

Checklist (Mandatory for new features)

  • Added Documentation
  • Added Unit Tests

Testing (Mandatory for all changes)

  • GPU Test: test-medium-connected.xml Passed
  • GPU Test: test-large-long.xml Passed

@stiber stiber added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request cleanup refactor doesn't change functionality, just improves code NG911 Recorders Re-engineering recorders major item serialization labels Oct 29, 2024
@stiber
Copy link
Contributor Author

stiber commented Oct 29, 2024

Ready for manual testing. @KamathScience will do GPU test and a long Growth simulation. @nyeshlur will look into what's up with the bad PlantUML conversion. @stiber will look into the tests.yml.

Divya Kamath and others added 3 commits October 29, 2024 11:56
ts911 somehow got duplicated in the merge.
…ml911recorder

[ISSUE-720] Remove Unused Functions from Xml911Recorder.cpp
@stiber stiber removed their assignment Nov 5, 2024
@stiber stiber requested a review from nyeshlur November 5, 2024 01:08
@stiber stiber self-assigned this Nov 5, 2024
@stiber stiber merged commit b507ae9 into master Nov 5, 2024
@stiber stiber deleted the release-v1.0 branch November 5, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cleanup documentation Improvements or additions to documentation enhancement New feature or request major item NG911 Recorders Re-engineering recorders refactor doesn't change functionality, just improves code serialization

Projects

None yet

Development

Successfully merging this pull request may close these issues.