Skip to content

Conversation

@d-kamath
Copy link
Collaborator

@d-kamath d-kamath commented Sep 9, 2024

Closes #697

Description

This PR includes several updates for serialization cleanup and improvements to the Serializer class:

  1. Removed code previously used to create synapses from synapse weights saved in the serialization file: Connections::createSynapsesFromWeights. This is no longer needed as we serialize all values including synapses.
  2. Updated comments and functions in the Serializer class for better clarity.
  3. Removed unused variables: totalNeurons_ and numCallerVertices_.
  4. Removed unused functions: Simulator::copyGPUSynapseToCPU and Simulator::copyCPUSynapseToGPU. These functions are moved into Model class.

Checklist (Mandatory for new features)

  • Added Documentation
  • Added Unit Tests

Testing (Mandatory for all changes)

  • GPU Test: test-medium-connected.xml Passed
  • GPU Test: test-large-long.xml Passed

@d-kamath d-kamath self-assigned this Sep 9, 2024
@d-kamath d-kamath requested a review from stiber September 9, 2024 22:50
@d-kamath d-kamath merged commit 095537e into development Sep 16, 2024
@d-kamath d-kamath deleted the issue-697-update-serializer-class branch September 16, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants