[ISSUE 371] Refactor Neural X Y Init

[Oelgazz]

closes #371

[jardiamj]

This looks good. There are just some empty lines and 4-space indentations that clang-format complains about in the C++ code and one small suggestion for the Python script.

[jardiamj]

I have one question about the purpose of the Python script. Is it meant to be a tool for generating the neural network graph, with x and y locations, for a given grid size (e.g. 10x10, 100x100)? if so, it might be more useful for the script to accept the grid size, through the command line for example.

[Oelgazz]

The purpose of the python script is to be a tool for users to generate GraphML files for the neural simulator. This script is the initial version and is updated in other branches to include parameters such as inhibitory and endogenously active neuron lists (see issues #641 and #642 ).

Because of this, it will be difficult for a user to input these details through the command line, as they will need to at least include the grid size, the inhibitory neuron list, the endogenously active neuron list, and the graph name. Also, since using GraphML will allow the possibility of having non-grid layouts, the grid size may become a (x,y) tuple list.

[jardiamj]

The purpose of the python script is to be a tool for users to generate GraphML files for the neural simulator. This script is the initial version and is updated in other branches to include parameters such as inhibitory and endogenously active neuron lists (see issues #641 and #642 ).

Because of this, it will be difficult for a user to input these details through the command line, as they will need to at least include the grid size, the inhibitory neuron list, the endogenously active neuron list, and the graph name. Also, since using GraphML will allow the possibility of having non-grid layouts, the grid size may become a (x,y) tuple list.

Great! That makes sense.

[stiber]

I'll create an issue relating to the above for future work. We actually have an algorithm to create the pattern of neuron types from the grid size, which is embedded in the Workbench neuron layout editor code (NLEdit). This would allow the tool to just take in something like the grid size and compute all of the other stuff.