Skip to content

Conversation

@Oelgazz
Copy link
Contributor

@Oelgazz Oelgazz commented May 2, 2024

closes #632

@Oelgazz Oelgazz added the testing label May 2, 2024
@Oelgazz Oelgazz requested a review from jardiamj May 2, 2024 21:03
@Oelgazz Oelgazz self-assigned this May 2, 2024
@Oelgazz
Copy link
Contributor Author

Oelgazz commented May 5, 2024

Currently 4 of the Graph Manager's tests fail. This is because of the Parameter Manager's dependency that is outlined in issue #634 . These tests will pass once that issue has been fixed.

@jardiamj
Copy link
Contributor

We indent to 3 spaces in our code base. I recommend adjusting the indentation spaces in your IDE or our clang-format check will fail.

@jardiamj
Copy link
Contributor

I know that most of the methods in the GraphManager class are thin wrappers around the Boost Graph Library but it might be a good idea to write tests for them. One could still make mistakes and break functionality. These tests would serve as a check against breaking functionality and also demonstrate how the GraphManager works.

@jardiamj
Copy link
Contributor

jardiamj commented May 25, 2024

The GraphManagerTests.cpp file doesn't pass the clang-format check because it uses the Windows-style end-of-line characters (\r\n) at the end of each line, instead of the Linux one (\n ). If you open the file with vim -b you will see a ^M character at the end of each line, which is how \r is rendered.

You must convert that file to the Linux end-of-line character (\n).

@Oelgazz Oelgazz merged commit f603427 into development May 29, 2024
@Oelgazz Oelgazz deleted the issue-632-graph-manager-unit-tests branch May 30, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants