[ISSUE-502] add an abstract base class ,RecordableBase defining the interface for recordable variables #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 13, 2023 11:01
stiber
requested changes
Dec 11, 2023
Contributor
stiber
left a comment
stiber
left a comment
There was a problem hiding this comment.
Mostly nitpicks and commenting requests. Two questions, with potential for discussion with others.
d-kamath
reviewed
Dec 12, 2023
d-kamath
reviewed
Dec 12, 2023
d-kamath
reviewed
Dec 12, 2023
d-kamath
reviewed
Dec 12, 2023
d-kamath
reviewed
Dec 12, 2023
added 4 commits
December 11, 2023 23:52
stiber
requested changes
Dec 14, 2023
Contributor
stiber
left a comment
stiber
left a comment
There was a problem hiding this comment.
Just one more thing (yes, I am annoying).
d-kamath
reviewed
Dec 18, 2023
Collaborator
d-kamath
left a comment
d-kamath
left a comment
There was a problem hiding this comment.
Good work, thank you Xiang
stiber
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #502
This pull request introduces a Recordable template for the EventBuffer class, incorporates a RecordableBase interface for the Recordable template, and adjusts the XmlRecorder code accordingly. The C++17 std::variant feature is utilized in the Recorder module to manage a list of different data types for recorded variables. Additionally, the unit tests for XmlRecorder have been revised to accommodate these changes.
The RecordableBase class serves as the base class for all variables that need to be recorded during simulation. It defines the interface for accessing information about recorded variables.
The Recordable class template extends the
RecordableBaseinterface and provides a concrete implementation for recording variables during simulation. It is templated to accommodate different data types for recording.