Skip to content

Conversation

@xiangli6
Copy link
Contributor

Closes #478

This PR creates a variable table within the XmlRecorder, which contains a list of variables that need to be recorded. With this enhancement, the XmlRecorder becomes capable of capturing and storing all event information for all neurons.

@xiangli6 xiangli6 added the Recorders Re-engineering recorders label Aug 15, 2023
@xiangli6 xiangli6 self-assigned this Aug 15, 2023
@xiangli6 xiangli6 changed the title [ISSUE-478] xml recorder all neurons [ISSUE-478] XmlRecorder records all events for all neurons Aug 15, 2023
@xiangli6 xiangli6 requested a review from stiber August 15, 2023 08:29
Copy link
Contributor

@stiber stiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor naming changes. Hopefully, at this point, everything will generically refer to "variables".

@xiangli6
Copy link
Contributor Author

By overloading the registerVariable() function, it becomes possible for the Xml recorder to record a vector of EventBuffer.

@xiangli6 xiangli6 requested a review from stiber August 23, 2023 22:42
@xiangli6 xiangli6 requested a review from stiber September 1, 2023 22:26
@xiangli6 xiangli6 merged commit 42d22d9 into development Sep 6, 2023
@stiber stiber deleted the issue-478-xmlRecorder-allNeurons branch November 9, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Recorders Re-engineering recorders

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XmlRecorder records all events for all neurons instead of a single neuron

3 participants