[ISSUE-410] Check switches on edgeType and make sure they have default cases #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Had trouble with comment indentation but it should be good now. |
stiber
approved these changes
Aug 2, 2023
stiber
pushed a commit
that referenced
this pull request
Feb 17, 2024
[ISSUE-410] Check switches on edgeType and make sure they have default cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #410
This PR checks to make sure switches on edgeType and makes sure they have default cases, with the ability to expand with throwing exceptions in the future if the switches return 0. In principle, return 0 in switch case if error.