[ISSUE 460] Enhancing build efficiency with the -j option in the make command #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrzej-Dawiec
added
good first issue
stiber
approved these changes
Jun 29, 2023
Contributor
stiber
left a comment
stiber
left a comment
There was a problem hiding this comment.
Looks good. Should double-check the time difference to verify that it is for the build and not the unit tests. Also would be good to compare both on one of our machines and within the GitHub action on their VM. Looking at this PR's build action, the build step itself took 1:51. In the most recent preceding run (from PR #590), the build step took 3:05. I'm not sure how consistent such timing would be, and it won't save the world, but it's not nothing!
Contributor
Author
|
After testing on Raiju Machine: |
stiber
pushed a commit
that referenced
this pull request
Feb 17, 2024
…ild-efficiency [ISSUE 460] Enhancing build efficiency with the -j option in the make command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #460
This PR adds:
Added "make -j" to line 18 on README.md
Added line 28 on tests.yml "run: make -j" for GitHub Actions Workflow file, noticed a 2ms time difference on raiju ./tests run with -j option enabled on GPU.