Skip to content

Conversation

@jardiamj
Copy link
Contributor

Closes #406

Removes the extra level in the Connections parameter node from the XML config file because it is not needed.

@jardiamj jardiamj requested a review from stiber June 19, 2023 23:27
@jardiamj jardiamj self-assigned this Jun 19, 2023
@jardiamj jardiamj changed the title Removed the unnecessary Connections parameter level from XML config file [issue #406] Removed the unnecessary Connections parameter level from XML config file Jun 20, 2023
Copy link
Contributor

@stiber stiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a code change? One other question.

@jardiamj jardiamj requested a review from stiber June 28, 2023 00:46
@jardiamj jardiamj requested a review from stiber July 11, 2023 17:38
@jardiamj jardiamj merged commit bf49aae into development Jul 19, 2023
@jardiamj jardiamj deleted the issue-406 branch July 19, 2023 05:17
stiber pushed a commit that referenced this pull request Feb 17, 2024
[issue #406] Removed the unnecessary Connections parameter level from XML config file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Connections parameters for ESCS simulations shouldn't have a extra level in the XML config file

3 participants