Conversation
| @@ -1,6 +1,5 @@ | |||
| { | |||
| "region": 13, | |||
| "altitude": 0, | |||
There was a problem hiding this comment.
Presumably altitude was used in the model at some point (to determine external temperature), but no longer seems to be part of the calculations.
| "lib": "Insulated floor", | ||
| "l": 0, | ||
| "h": 0, | ||
| "perimeter": 6.8, |
There was a problem hiding this comment.
perimeter does not seem to be an input or output of the OpenBEM calcs.
| // | ||
| //---------------------------------------------------------------------------------------------*/ | ||
|
|
||
| calc.fabric = function (data, solar_acces_factor) { |
| // SAP assumes we are using curtains: paragraph 3.2, p. 15, SAP2012 | ||
| data.fabric.elements[z].wk = data.fabric.elements[z].netarea * (1 / (1 / data.fabric.elements[z].uvalue + 0.04)); | ||
| } else { | ||
| // SAP assumes we are using curtains: paragraph 3.2, p. 15, SAP2012 |
There was a problem hiding this comment.
comment is valid for line above (about windows) but not for this line.
| // Monthly average external temperature from Table U1 | ||
| // for (var i=1; i<13; i++) data['96-'+i] = table_u1[i.region][i-1]-(0.3 * i.altitude / 50); | ||
|
|
||
| // See utilisationfactor.js for calculation |
There was a problem hiding this comment.
There is no longer a separate utilisationfactor.js file
| // for (var i=1; i<13; i++) data['96-'+i] = table_u1[i.region][i-1]-(0.3 * i.altitude / 50); | ||
|
|
||
| // See utilisationfactor.js for calculation | ||
| var Te = []; |
There was a problem hiding this comment.
Moved this bit of code down below the "7. Mean internal temperature (heating season)" comment, as this seems to be the bit of code that is actually relevant to the comment.
| } | ||
|
|
||
|
|
||
| // This function is no longer actually used anywhere... |
There was a problem hiding this comment.
Tempted to delete this, but thought I'd just point out that it's currently redundant.
1 participant
Reading through the OpenBEM model, there were quite a few pieces where the code could do with some tidying up (eg commented out code, duplicate lines, typos, unused variables).
Hope this is helpful.