Add i18n-english for frontend #54#57
Open
yurenchen000 wants to merge 14 commits intoTransparentLC:masterfrom
Open
Add i18n-english for frontend #54#57yurenchen000 wants to merge 14 commits intoTransparentLC:masterfrom
yurenchen000 wants to merge 14 commits intoTransparentLC:masterfrom
Conversation
yurenchen000
force-pushed
the
ui_i18n_eng
branch
2 times, most recently
from
b30585c to
ad192b6
Compare
Owner
|
LGTM, extracting and translating strings is not an easy task. Thanks for your contribution! That's how i18n should be done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.