This repository was archived by the owner on Dec 3, 2025. It is now read-only.
use detect-node module due to unreliability of global window variable in some cases#1
Open
charleskoehl wants to merge 2 commits intoTouchInnovation:masterfrom
charleskoehl:master
Open
use detect-node module due to unreliability of global window variable in some cases#1charleskoehl wants to merge 2 commits intoTouchInnovation:masterfrom charleskoehl:master
charleskoehl wants to merge 2 commits intoTouchInnovation:masterfrom
charleskoehl:master
Conversation
…ule, which takes into account the unreliability of the global window variable described here: https://stackoverflow.com/questions/17575790/environment-detection-node-js-or-browser
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect whether running in node or browser using the ‘detect-is-node’ module, which accounts for the window global being declared through JS DOM.