Added a catch for if a player is caged and kicked. Resolves #1789 #2041
Conversation
|
|
||
| import me.totalfreedom.totalfreedommod.banning.Ban; | ||
| import me.totalfreedom.totalfreedommod.caging.CageData; | ||
| import me.totalfreedom.totalfreedommod.player.FPlayer; |
There was a problem hiding this comment.
I think you meant to put these in the other file..
There was a problem hiding this comment.
These will need to be removed, methinks.
There was a problem hiding this comment.
Yes, thats where I changed implementation mid-way through. Let me fix that.
| } | ||
| } | ||
|
|
||
| @EventHandler(priority = EventPriority.MONITOR, ignoreCancelled = true) |
There was a problem hiding this comment.
Why ignoreCancelled? If the event is cancelled, why do you need to remove the cage?
There was a problem hiding this comment.
Wild's implementation is correct. If the kick event is cancelled, the player isn't kicked, so the cage data shouldn't be removed. ignoreCancelled causes the event handler to skip processing if the event is cancelled.
There was a problem hiding this comment.
Oh, never mind then. I was thinking the other way around.
|
|
||
| import me.totalfreedom.totalfreedommod.banning.Ban; | ||
| import me.totalfreedom.totalfreedommod.caging.CageData; | ||
| import me.totalfreedom.totalfreedommod.player.FPlayer; |
There was a problem hiding this comment.
These will need to be removed, methinks.
|
@JeromSar Unused imports removed. |
|
Thanks for contributing! Your PR will be merged soon. |
3 participants
Resolves #1789